Feat: Add ability to exclude dependencies in the requirements lock file#3544
Merged
izeigerman merged 1 commit intomainfrom Dec 20, 2024
Merged
Conversation
tobymao
reviewed
Dec 20, 2024
| return "" | ||
|
|
||
|
|
||
| def _build_requirements( |
Collaborator
Author
There was a problem hiding this comment.
Cause context_diff should only care about the final set of requirements. Because of lazy computation I had to pass both provided_requirements and excluded_requirements into the instance itself just so that the actual value is computed later. This presented additional complications when it came to creating the no_diff instance, since I had to pass the excluded_requirements even though requirements were sourced from the target environment.
tobymao
approved these changes
Dec 20, 2024
georgesittas
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ability to opt-out some dependencies and prevent them from being included by the automatic dependency detection logic.