Docs: clarify interval_unit definition and use in lookback/batch size#3613
Merged
Docs: clarify interval_unit definition and use in lookback/batch size#3613
Conversation
tobymao
approved these changes
Jan 10, 2025
sungchun12
suggested changes
Jan 10, 2025
sungchun12
reviewed
Jan 10, 2025
sungchun12
reviewed
Jan 10, 2025
treysp
force-pushed
the
trey/int-unit-lookback
branch
from
5289e16 to
2ffdfc9
Compare
tobymao
reviewed
Jan 10, 2025
tobymao
approved these changes
Jan 10, 2025
sungchun12
approved these changes
Jan 13, 2025
Contributor
sungchun12
left a comment
sungchun12
left a comment
There was a problem hiding this comment.
Made a couple suggestions, and this is a welcome improvement to these config definitions. Great use of examples.
treysp
force-pushed
the
trey/int-unit-lookback
branch
from
2ffdfc9 to
161fc39
Compare
Co-authored-by: Sung Won Chung <sungwonchung3@gmail.com>
treysp
force-pushed
the
trey/int-unit-lookback
branch
from
161fc39 to
6d6fab2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.