Fix: Physical view not being created when needed for non-deployable indirect non-breaking snapshots#3619
Merged
izeigerman merged 1 commit intomainfrom Jan 13, 2025
Conversation
tobymao
approved these changes
Jan 11, 2025
…ndirect non-breaking snapshots
izeigerman
force-pushed
the
fix-missing-physical-view-indirect-non-breaking-snapshot
branch
from
14818fc to
d77a48a
Compare
izeigerman
deleted the
fix-missing-physical-view-indirect-non-breaking-snapshot
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In very rare scenarios, there might be a snapshot of a view model that is representative but not deployable, while the corresponding physical view has not yet been created for it.
One example of this happening is the following scenario:
Model DAG: A (forward-only) -> B (non-forward-only) -> C (view).
dev. Everything categorized as forward-onlyINDIRECT_BREAKING. The deployable view hasn't been created at this point*prodwithout deploying the 2nd change.dev. C is nowINDIRECT_NON_BREAKING. Applying this change fails with missing view*The view hasn't been created at this point due to a different issue which is outlined in this PR: #2899