Fix: The inference of the default plan start#3628
Merged
izeigerman merged 1 commit intomainfrom Jan 14, 2025
Merged
Conversation
Contributor
|
so if end is 1/2 00:00, then start will be 1/1, but if end is 1/1 15:00 then start will be 12/31. i guess that's correct |
tobymao
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic was overly simplistic and worked well only for daily models, while yielding poor results for models with a coarser cadence (weekly, monthly).
The new logic is based on interval units of models that constitute a plan.