Fix: no models ready to run message shouldn't error #3644
Merged
Conversation
georgesittas
approved these changes
Jan 16, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Thanks for checking this out! FYI @benfdking.
treysp
force-pushed
the
trey/fix-next-model-start
branch
from
32375de to
c67eb29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no models are ready to run, the
sqlmesh runcommand issues a message stating when the next model will be ready to run.Some model kinds, like
seedandsymbolic, do not have a "ready" time. Currently, we error if a project only contains these kinds of models.This PR updates the code to handle this situation, omitting the time when next model ready from the message if it cannot be calculated.