Fix: Include unrendered query into the metadata hash#3710
Merged
izeigerman merged 1 commit intomainfrom Jan 25, 2025
Merged
Conversation
izeigerman
force-pushed
the
fix-underendered-query-metadata-hash
branch
from
1b633fa to
ac3d87b
Compare
izeigerman
force-pushed
the
fix-underendered-query-metadata-hash
branch
from
ac3d87b to
dc8b3b2
Compare
tobymao
reviewed
Jan 25, 2025
|
|
||
| @property | ||
| def _additional_metadata(self) -> t.List[str]: | ||
| return [*super()._additional_metadata, gen(self.query)] |
Contributor
There was a problem hiding this comment.
nit, but this could be double counted in 1385 in certain cases, any way we can cache that so we don't pay a perf penalty
i'm a little bit afraid this is going to kill performance
tobymao
approved these changes
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.