Skip to content

chore: automatically mark lsp tests as fast#4665

Merged
benfdking merged 1 commit intomainfrom
automatically_mark_fast
Jun 5, 2025
Merged

chore: automatically mark lsp tests as fast#4665
benfdking merged 1 commit intomainfrom
automatically_mark_fast

Conversation

@benfdking
Copy link
Copy Markdown
Contributor

No description provided.

@benfdking benfdking requested a review from Copilot June 5, 2025 10:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes the fast mark for all LSP tests by removing individual @pytest.mark.fast decorators and adding a pytestmark in a new conftest.py.

  • Removed per-test @pytest.mark.fast decorators from all LSP tests
  • Added tests/lsp/conftest.py to apply pytestmark = pytest.mark.fast globally
  • Cleaned up redundant import pytest statements where no longer needed

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
tests/lsp/test_reference_macro_multi.py Removed decorator; should remove unused import pytest.
tests/lsp/test_reference_macro.py Removed decorator; should remove unused import pytest.
tests/lsp/test_reference.py Removed decorators; should remove unused import pytest.
Comments suppressed due to low confidence (3)

tests/lsp/test_reference_macro_multi.py:1

  • Remove the now-unused import pytest since the fast mark is applied globally in conftest.py.
import pytest

tests/lsp/test_reference_macro.py:1

  • Remove the now-unused import pytest since the fast mark is applied globally in conftest.py.
import pytest

tests/lsp/test_reference.py:1

  • Remove the now-unused import pytest since the fast mark is applied globally in conftest.py.
import pytest

@benfdking benfdking force-pushed the automatically_mark_fast branch from e42a1ad to 25bafbe Compare June 5, 2025 10:46
@benfdking benfdking force-pushed the automatically_mark_fast branch from 25bafbe to a79a7fa Compare June 5, 2025 10:46
@benfdking benfdking enabled auto-merge (squash) June 5, 2025 10:53
@benfdking benfdking merged commit aedb472 into main Jun 5, 2025
23 checks passed
@benfdking benfdking deleted the automatically_mark_fast branch June 5, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants