chore: automatically mark lsp tests as fast#4665
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes the fast mark for all LSP tests by removing individual @pytest.mark.fast decorators and adding a pytestmark in a new conftest.py.
- Removed per-test
@pytest.mark.fastdecorators from all LSP tests - Added
tests/lsp/conftest.pyto applypytestmark = pytest.mark.fastglobally - Cleaned up redundant
import pyteststatements where no longer needed
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/lsp/test_reference_macro_multi.py | Removed decorator; should remove unused import pytest. |
| tests/lsp/test_reference_macro.py | Removed decorator; should remove unused import pytest. |
| tests/lsp/test_reference.py | Removed decorators; should remove unused import pytest. |
Comments suppressed due to low confidence (3)
tests/lsp/test_reference_macro_multi.py:1
- Remove the now-unused
import pytestsince thefastmark is applied globally inconftest.py.
import pytest
tests/lsp/test_reference_macro.py:1
- Remove the now-unused
import pytestsince thefastmark is applied globally inconftest.py.
import pytest
tests/lsp/test_reference.py:1
- Remove the now-unused
import pytestsince thefastmark is applied globally inconftest.py.
import pytest
e42a1ad to
25bafbe
Compare
25bafbe to
a79a7fa
Compare
georgesittas
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.