fix: forall with only one criteria#701
Merged
tobymao merged 2 commits intoSQLMesh:mainfrom Apr 13, 2023
Merged
Conversation
Apply the `NOT` predicate before `REDUCE` to handle cases where only one criteria is specified.
tobymao
reviewed
Apr 13, 2023
sqlmesh/core/audit/builtin.py
Outdated
| @criteria, | ||
| c -> NOT (c) | ||
| ), | ||
| (l, r) -> (l) OR (r) |
Contributor
There was a problem hiding this comment.
don't need the extra parens can just do l or r because you're already wrapping everything in NOT (x)
Contributor
Author
There was a problem hiding this comment.
I'm always pretty cautious about this. Given that parens are cheap, I tend to add them regardless especially in "code generators" like this. Removed in d098677
tobymao
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the
NOTpredicate beforeREDUCEto handle cases where only one criteria is specified.