Skip to content

Conversation

@firasrg
Copy link
Member

@firasrg firasrg commented May 14, 2023

title: initial improvements on 1st parts;

comments:

  • prelude.md & getting_started.md: expand intro by adding old-school developers and professionals;
  • benefits_of_java.md: new file to talk about major benefits in Java;

title: initial improvements on 1st parts;

comments:
- prelude.md & getting_started.md: expand intro by adding old-school developers and professionals;
- benefits_of_java.md: new file to talk about major benefits in Java;
@firasrg firasrg requested review from a team as code owners May 14, 2023 18:21
@firasrg
Copy link
Member Author

firasrg commented May 14, 2023

Hello reviewers! This is an initial PR, I want to show you what I've done so far and discuss, before I go further. Thanks

Copy link
Collaborator

@bowbahdoe bowbahdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the material content in the "why java" section

comments:
- rename section "benefits_of_java" to "Why Java?"
- Many improvements in  "Why Java?" page.
- start.sh removed;
@firasrg
Copy link
Member Author

firasrg commented Jun 3, 2023

Hello @bowbahdoe ! I've made a new update, please evaluate it and give me your feedback. thanks in advance

@bowbahdoe
Copy link
Collaborator

Sorry im taking so long, as usual my general feedback right now is

  • Better than last time
  • I don't like linking out to low quality/unreliable websites like geeksforgeeks or random unafiliated blogs. Like, this link is just kinda...bad https://www.protechtraining.com/blog/post/modern-java-for-the-modern-age-by-nick-maiorano-937
  • Your "why java" still misses the mark. You talk about OOP and FP at a point in the track where we don't assume they even know what methods are
  • Your use of emojis is still...off. I'm not embargoing them but its tonal whiplash
  • The words you bold don't exactly make sense to bold. Hard to explain exactly why

@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jul 10, 2023
@bowbahdoe
Copy link
Collaborator

bumping to keep alive.

@firasrg
Copy link
Member Author

firasrg commented Jul 10, 2023

Hello @bowbahdoe ! thanks for keeping alive!

I'm sorry I was busy in priorities and holidays. I hope you're doing good; what's new with this PR ?


While functional programming **is not** unique to Java, its inclusion in the language provides Java developers with the flexibility to leverage functional programming concepts alongside object-oriented programming!

> As an example, compared to [JavaScript](https://developer.mozilla.org/fr/docs/Web/JavaScript), which is considered a vert popular language, empowered with functional programming, Java is still stronger than JavaScript, as JavaScript [still lacks some object-oriented concepts](https://stackoverflow.com/a/108773).
Copy link

@illuminator3 illuminator3 Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? "vert"


The language has evolved over time, incorporating new features and improvements while maintaining backward compatibility with modern business needs. Java's maturity is evident in the stability of its frameworks, patterns, toolset, and practices.

It has an extensive documentation and resources. You can find comprehensive documentation, tutorials, and examples to help you learn it easily. The vast Java community also provides support through forums, online chat communities, and **open-source** projects.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the "an"

@bowbahdoe
Copy link
Collaborator

@firasrg Nothing right now. I've been distracted with other things. I'm coming back into book stuff because the playground work is kicking off.

@github-actions github-actions bot added valid This issue/PR is valid and should be kept open, even if it is not worked on yet. and removed stale labels Jul 11, 2023
@firasrg firasrg closed this by deleting the head repository Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

valid This issue/PR is valid and should be kept open, even if it is not worked on yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants