-
-
Notifications
You must be signed in to change notification settings - Fork 104
Description
Problem
Our reminder system (/reminder create ...) sometimes fails to send the reminder. This is totally normal and can happen due to Discord/JDA hicups and whatever.
But, when it happens, we completely lose the message and it does not retry. That is a problem.
Fix
Instead, the system should just retry failed reminders (maybe 3 times), by putting them into the DB again with an Instant that is maybe set 1 minute into the future. If it ultimately failed, the log message should log the actual reminder-text and the target user, so that the reminder can be rerouted manually by an admin at least.
Details
For the failure count (~3 times), we likely need to add an additional column in the reminder DB table. Reminders are send from RemindRoutine.java, the table was initially created in V8__Add_Pending_Reminders.sql, the migration script V10__Alter_Top_Helper_Message_Length.sql shows how one can add a new column to an existing table.