Skip to content

[BugFix] Discord embed, resume views, and scripts loading issues #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

[BugFix] Discord embed, resume views, and scripts loading issues #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/src/main/java/org/togetherjava/website/Application.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package org.togetherjava.tjbot.website;
package org.togetherjava.website;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

/**
* Spring boot application to serve the bots welcome webpage.
* Spring boot application to serve the website.
*/
@SpringBootApplication
public class Application {
Expand Down
2 changes: 1 addition & 1 deletion website/src/main/java/org/togetherjava/website/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/**
* Main package for the projects' website.
*/
package org.togetherjava.tjbot.website;
package org.togetherjava.website;
16 changes: 8 additions & 8 deletions website/src/main/resources/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,14 @@ <h3>Contact the Owners</h3>
</footer>

<!-- Scripts -->
<script src="assets/js/jquery-3.6.1.min.js" async></script>
<script src="assets/js/jquery.scrollex.min.js" async></script>
<script src="assets/js/jquery.scrolly.min.js" async></script>
<script src="assets/js/browser.min.js" async></script>
<script src="assets/js/breakpoints.min.js" async></script>
<script src="assets/js/util.js" async></script>
<script src="assets/js/main.js" async></script>
<script src="https://cdn.jsdelivr.net/npm/@widgetbot/html-embed@1.0.0"></script>
<script src="assets/js/jquery-3.6.1.min.js"></script>
<script src="assets/js/jquery.scrollex.min.js" ></script>
<script src="assets/js/jquery.scrolly.min.js"></script>
<script src="assets/js/browser.min.js" ></script>
<script src="assets/js/breakpoints.min.js" ></script>
<script src="assets/js/util.js" ></script>
<script src="assets/js/main.js" ></script>
<script src="https://cdn.jsdelivr.net/npm/@widgetbot/html-embed@1.3.0"></script>
Comment on lines -233 to +240
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this is probably a sane choice, its likely important to figure out why async was added in the first place.
i would not be surprised if it was done to cut down response time for the website which in turn increases SEO massively.

so if thats the case, just undoing this might not be a good choice given that the websites primary role is to be SE-relevant.

Copy link
Member

@Zabuzard Zabuzard Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was done in the big SEO PR: #10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since develop doesnt have it to begin with, merging this will hence not make the SEO worse. So we can accept this change for now.



</body>
Expand Down