feat: Update collection name handling in ingestion pipeline for VectorIngestionPipeline!

[amindadgar]

Summary by CodeRabbit

• Refactor
  • Updated the logic for determining collection names during document processing to improve consistency with later pipeline stages. This change does not affect user-facing features or outputs.

[coderabbitai]

Walkthrough

The logic for assigning the collection_name in the process_document activity was updated. Instead of combining communityId and platformId when collectionName is missing, the code now uses only platformId and defers full collection name construction to the CustomIngestionPipeline class, as clarified by a new comment.

Changes

File(s)	Change Summary
hivemind_etl/simple_ingestion/pipeline.py	Updated collection_name assignment logic and added a clarifying comment about name construction.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant process_document
    participant CustomIngestionPipeline

    User->>process_document: Submit ingestion request
    process_document->>process_document: Determine collection_name (platformId if not provided)
    process_document->>CustomIngestionPipeline: Pass collection_name and communityId
    CustomIngestionPipeline->>CustomIngestionPipeline: Reconstruct full collection name ([communityId]_[collection_name])

Loading

Possibly related PRs

• feat: updated to get latest summary docs! #31: Modifies collection name construction logic, shifting from a combined string to separating platformId and communityId, similar to the changes in this PR.

Poem

A tweak to the names, a hop in the code,
No longer combined, just platform bestowed.
The pipeline will join them, as rabbits unite,
Collection names tidy, all feels just right.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ec3a57 and 4986c4c.

📒 Files selected for processing (1)

• hivemind_etl/simple_ingestion/pipeline.py (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: amindadgar
PR: TogetherCrew/temporal-worker-python#39
File: hivemind_summarizer/activities.py:97-100
Timestamp: 2025-05-12T11:24:54.953Z
Learning: In the temporal-worker-python project, `CustomIngestionPipeline` expects collection names WITHOUT the community_id prefix (e.g., `{platform_id}_summary`), while direct Qdrant queries use collection names WITH the community_id prefix (e.g., `{community_id}_{platform_id}_summary`).

hivemind_etl/simple_ingestion/pipeline.py (1)

Learnt from: amindadgar
PR: TogetherCrew/temporal-worker-python#39
File: hivemind_summarizer/activities.py:97-100
Timestamp: 2025-05-12T11:24:54.953Z
Learning: In the temporal-worker-python project, `CustomIngestionPipeline` expects collection names WITHOUT the community_id prefix (e.g., `{platform_id}_summary`), while direct Qdrant queries use collection names WITH the community_id prefix (e.g., `{community_id}_{platform_id}_summary`).

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: ci / lint / Lint
• GitHub Check: ci / test / Test

🔇 Additional comments (2)

hivemind_etl/simple_ingestion/pipeline.py (2)

76-77: Excellent documentation addition!

The added comment clearly explains the responsibility shift and the expected format for collection name reconstruction. This provides valuable context for future developers and improves code maintainability.

---

70-73:

❓ Verification inconclusive

LGTM! Change aligns with CustomIngestionPipeline expectations.

The updated logic correctly uses only platformId when collectionName is None, which aligns with the retrieved learnings that CustomIngestionPipeline expects collection names WITHOUT the community_id prefix. This change properly defers the full collection name construction to the pipeline class.

Consider adding validation to ensure platformId is not None or empty:

---

🏁 Script executed:

#!/bin/bash
# Description: Check if there are any validations for platformId in the schema or elsewhere
rg -A 5 -B 5 "platformId.*None|platformId.*empty|platformId.*null" 
ast-grep --pattern 'class IngestionRequest {
  $$$
  platformId: $TYPE
  $$$
}'

Length of output: 150

---

#!/bin/bash
# Locate where IngestionRequest is defined and inspect its attributes

# Find the file containing the IngestionRequest class
filepath=$(rg -l "class IngestionRequest" -g "*.py")
echo "Found IngestionRequest in: $filepath"

# Show the class definition and first 200 lines to inspect platformId typing and defaults
sed -n '1,200p' "$filepath"

---

#!/bin/bash
# Locate and inspect the IngestionRequest class to see how platformId is defined/validated

# 1. Find the file containing the IngestionRequest definition
ingestion_file=$(rg -l "class IngestionRequest" -g "*.py")
echo "Found IngestionRequest in: $ingestion_file"

# 2. Print the class definition (first 200 lines)
echo -e "\n=== IngestionRequest class definition (first 200 lines) ==="
sed -n '1,200p' "$ingestion_file"

# 3. Show where platformId is declared or referenced within that file
echo -e "\n=== Occurrences of platformId in $ingestion_file ==="
rg -n "platformId" "$ingestion_file"

---

Collection name logic is correct; please verify platformId validation

The change to use only platformId when collectionName is None aligns with CustomIngestionPipeline’s expectations. Before merging, ensure that platformId can never be None or empty at runtime:

• File: hivemind_etl/simple_ingestion/pipeline.py, lines 70-73

if ingestion_request.collectionName is None:
    collection_name = ingestion_request.platformId
else:
    collection_name = ingestion_request.collectionName

• Verify in the IngestionRequest schema or upstream validation that platformId is required and non-empty.
• Alternatively, add a guard here to raise an error if platformId is falsy:

if ingestion_request.collectionName is None:
    if not ingestion_request.platformId:
        raise ValueError("platformId must be provided when collectionName is not set")
    collection_name = ingestion_request.platformId
else:
    collection_name = ingestion_request.collectionName

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.