feat: mediaWiki load max 10 parallel processing!

[amindadgar]

Summary by CodeRabbit

• Chores
  • Improved system performance consistency by limiting the number of concurrent threads used during document processing.

[coderabbitai]

Walkthrough

The MediawikiETL class's load method was updated to explicitly set the maximum number of worker threads to 10 in the ThreadPoolExecutor, thereby capping the level of concurrency during parallel document batch processing.

Changes

File(s)	Change Summary
hivemind_etl/mediawiki/etl.py	Set max_workers=10 in ThreadPoolExecutor within load method to limit concurrency.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MediawikiETL
    participant ThreadPoolExecutor
    participant WorkerThreads

    User->>MediawikiETL: call load()
    MediawikiETL->>ThreadPoolExecutor: create (max_workers=10)
    loop For each document batch
        MediawikiETL->>ThreadPoolExecutor: submit batch task
        ThreadPoolExecutor->>WorkerThreads: process batch (up to 10 in parallel)
    end
    WorkerThreads-->>MediawikiETL: return results
    MediawikiETL-->>User: load complete

Loading

Possibly related PRs

• feat: Implement batch processing for document ingestion in MediawikiETL #52: Both PRs modify the load method of the MediawikiETL class to improve document ingestion by controlling concurrency and batch processing, indicating related changes to how documents are processed in parallel and in chunks.

Poem

Ten threads now march in neat array,
To process docs without delay.
No more wild spawns, just order and grace,
As batches move at a measured pace.
The ETL hums, the data flows—
A rabbit nods, and onward it goes! 🐇

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

hivemind_etl/mediawiki/etl.py (1)

109-109: Consider making the max_workers configurable.

The change to limit concurrency to 10 workers is good for resource management and preventing overwhelming of the Qdrant service. However, the hard-coded value may not be optimal for all deployment environments.

Consider making this configurable via constructor parameter or environment variable:

-        with ThreadPoolExecutor(max_workers=10) as executor:
+        max_workers = int(os.getenv("MEDIAWIKI_ETL_MAX_WORKERS", "10"))
+        with ThreadPoolExecutor(max_workers=max_workers) as executor:

Or add it as a constructor parameter:

 def __init__(
     self,
     community_id: str,
     namespaces: list[int],
     platform_id: str,
     delete_dump_after_load: bool = True,
+    max_workers: int = 10,
 ) -> None:

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74b2348 and cc09908.

📒 Files selected for processing (1)

• hivemind_etl/mediawiki/etl.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: ci / build-push / Build + Push Image