NB update #67
Merged
NB update #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added plots for a) Pool Growth b) Token Ratio c) Fees
added plots for - Pool Growth - Token Ratio - Fees and cleared output :)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- update NB1 - added plots - cleaned up charts
- new name (stating the pool) - all text final - all links final - all plots final - ONLY MISSING is final check after update .json file
Contributor
Author
|
Please merge NBupdate to dev to include final version of notebook @Ramarti |
|
@AngelaKTE IMO the same point I made in #45 about dai_balance dominating weth_balance renders the ratio indicator as it currently stands somewhat meaningless Instead, I'd suggest the ratio of value in each token If you can make this a normalized stacked area chart (and I'm sure you can make a much more visually appealing version than the following 🙈 ), it would be even better to showcase the fact that the value of the tokens held by the pool constantly hovers the pre-defined weights, as per the design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added plots for
and finally cleared output in 2nd commit