1inch aggregate swap fix #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut it still doesn't show up in the final JSON for some reason)
…group_1inch_aggregated_swaps() Current situation: turn_events_into_actions() detects 1inch aggregate swaps and makes them into separate Action objects. However, these separate Action objects are still grouped together later in produce_actions() by txhash. This messes up classify_actions(). So the function that turned the dict (that classified Action groups by txhash) needs to be made more complex. As new Defi startups figure out more ways to make trickier transactions, we might need to abandon the assumption of grouping by txhash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.