Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1: Web Client #121

Merged
merged 73 commits into from
Apr 28, 2022
Merged

Milestone 1: Web Client #121

merged 73 commits into from
Apr 28, 2022

Conversation

TomBenDor
Copy link
Owner

No description provided.

Tom-stack3 and others added 30 commits March 29, 2022 18:38
* Created React app, logo and ico files

* Moved files to web-client folder
Signin, Signup routes

Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
* Added SignIn logic

* Added SignIn logic

* Added SignUp logic

* Added two checks for password creation

* Minor change
* Set action to run on Windows

* Update package.json

* Not triggered by push

* Fix warnings
* Added use of variables
* Formatted code

* Accessing image uploaded by user
Added `accept="image/*"` to form
Made button

Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
* Added live field errors

* Created validation functions for each field

* Deleted use of validateFields()
* added display name checks

* User can't type characters according to regex

* Added comment

Co-authored-by: Tommy <tommy.zaft1@gmail.com>
* fixed signup

* denies signup if password is invalid

* Fixed "don't yell at me I will get there"

* Shows confirm password error

* Fixed all issues and ux enhancements

Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
* Centering

* Fixed resizing horizontally

Co-authored-by: Tommy <tommy.zaft1@gmail.com>
* Added username and display name errors

* Update web-client/src/components/SignUpForm.js

* Update web-client/src/components/SignUpForm.js

Co-authored-by: Tommy Zaft <76645845+Tom-stack3@users.noreply.github.com>

* minor

* Use validation function in clear function

* minor

* Update web-client/src/components/SignUpForm.js

Co-authored-by: Tommy Zaft <76645845+Tom-stack3@users.noreply.github.com>

Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
Co-authored-by: Tommy Zaft <76645845+Tom-stack3@users.noreply.github.com>
* split css file

* Fixed auth folder

Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
* Moved DB to App.js

* Current contact

* Switching contact
Tom-stack3 and others added 10 commits April 21, 2022 08:12
* Fixed input value

* reformat

* Show password button icon changes (#112)

Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>

Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
Co-authored-by: OmerShoulstein <omershoulstein@gmail.com>
Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
@TomBenDor TomBenDor added the draft Under constructions label Apr 25, 2022
@Tom-stack3
Copy link
Collaborator

The milestone-1 branch shouldn't be deleted after merge.

@TomBenDor TomBenDor removed the draft Under constructions label Apr 28, 2022
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astonishing piece of work! 🙃

Copy link
Collaborator

@OmerShoulstein OmerShoulstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous job!

@TomBenDor TomBenDor merged commit 136214a into master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants