feat: add coroutine support via ENABLE_CORO cmake flag#7
Merged
Conversation
Member
|
Thank you sooo much for this! I am not familiar with C++ coroutines hahahaha so this pull request is a huge blessing! ❤️ |
null8626
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for D++ asynchronous coroutines.
For this to work you must:
DPP_COROcmake flagENABLE_COROflagBuilding with this flag will reveal new functions in the SDK client. Each of the functions such as
get_userwill have a coroutine equivalent starting withco_(this is the naming convention of D++, copied from C++ standards). The coroutine equivalent will have no callback parameter and can be awaited.So, the basic example would become instead:
This is nicer, as it avoids callback hell, and program flow reads in a nicer way. This is of course completely optional and if you don't want to use coroutines, or if you can't, the existing API calls will work exactly as before.