Skip to content

Default generate_force_convergence_fn(include_cell_forces: bool) to True to match ASE #208

@janosh

Description

@janosh

the new include_cell_forces keyword of generate_force_convergence_fn added in #203 defaults to False (which is the original behavior) but should be changed to True to match ASE.

https://github.com/Radical-AI/torch-sim/blob/2e4a40821a99355b0bfedeb2b2398738baed3743/torch_sim/runners.py#L287-L292

Metadata

Metadata

Assignees

No one assigned

    Labels

    geo-optGeometry optimization

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions