-
Notifications
You must be signed in to change notification settings - Fork 55
Support different temperatures in batches #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…est functionality
|
LGTM. Nice use of scatter operation, btw :) |
|
Something seems wrong in the graph pes test- https://github.com/Radical-AI/torch-sim/actions/runs/14406977027/job/40405760127?pr=123 Unrelated to this PR. |
|
@jla-gardner @CompRhys, seems like one of the |
I realize that I didn't implement what I thought I had for the rattle, I was planning to do closer to perturbed = struct.copy()
for site in perturbed:
magnitude = rng.weibull(gamma)
vec = rng.normal(3) # TODO maybe make func recursive to deal with 0-vector
vec /= np.linalg.norm(vec) # unit vector
site.coords += vec * magnitude
site.to_unit_cell(in_place=True)based on CGCNN+P from MBD but didn't as I didn't sample the directions. We should just replace with a gaussian rattle will be easier. --edit I fixed this in 1344660. |
Summary
Include a summary of major changes in bullet points:
statecauses an OOM error ifstateis too large #128Checklist
Work-in-progress pull requests are encouraged, but please enable the draft status on your PR.
Before a pull request can be merged, the following items must be checked:
Run ruff on your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit installand a check will be run prior to allowing commits.