Skip to content

Conversation

@janosh
Copy link
Collaborator

@janosh janosh commented Apr 12, 2025

add get_module_graph_dot_file.py script to generate DOT representation of torch_sim module graph

torch-sim-module-graph

… torch_sim module graph

- with connectedness color gradient generation and line counting
- CLI args for customizable layout parameters
- Created a corresponding `module_graph.typ` file to visualize the generated DOT file.
@cla-bot cla-bot bot added the cla-signed Contributor license agreement signed label Apr 12, 2025
@janosh janosh added the docs Improvements or additions to documentation label Apr 12, 2025
@janosh
Copy link
Collaborator Author

janosh commented Apr 12, 2025

@orionarcher @AdeeshKolluru the huggingface login CI step is flaky:

The token has not been saved to the git credentials helper. Pass `add_to_git_credential=True` in this function directly or `--add-to-git-credential` if using via `huggingface-cli` if you want to set the git credential as well.
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/huggingface_hub/utils/_http.py", line 409, in hf_raise_for_status
    response.raise_for_status()
  File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/requests/models.py", line 1024, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://huggingface.co/api/whoami-v2

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/huggingface_hub/hf_api.py", line 1737, in whoami
    hf_raise_for_status(r)
  File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/huggingface_hub/utils/_http.py", line 473, in hf_raise_for_status
    raise _format(HfHubHTTPError, message, response) from e
huggingface_hub.errors.HfHubHTTPError: 403 Forbidden: None.
Cannot access content at: https://huggingface.co/api/whoami-v2.
Make sure your token has the correct permissions.

@orionarcher
Copy link
Collaborator

orionarcher commented Apr 12, 2025

Good catch @janosh. Raised an issue #133 to note this. As an interim solution, we can modify hugging face step in the action to only trigger for the fairchem models, that will reduce the frequency of this failure.

The 5.3_Hot_Swap_WBM.py script is also flaky.

@janosh
Copy link
Collaborator Author

janosh commented Apr 12, 2025

@abhijeetgangan @orionarcher any reservations about showing this in the readme? could be info overload. but the docs (https://radical-ai.github.io/torch-sim/user/introduction.html) import the readme and i would like to show it in the docs...

@janosh janosh enabled auto-merge (squash) April 13, 2025 14:03
@janosh janosh merged commit ef23850 into main Apr 13, 2025
84 of 85 checks passed
@janosh janosh deleted the dot-module-graph branch April 13, 2025 14:10
@orionarcher
Copy link
Collaborator

Thanks @janosh! Very cool feature

@janosh
Copy link
Collaborator Author

janosh commented Apr 13, 2025

honestly less insightful than i expected. but the work was already done so might as well use it. as expected state, models.interface and neighbors are frequently imported across the package. transforms was a bit of a surprise. glad i bumped the coverage on that before release. if we find bugs, at least the tests will be easy to update. 2nd surprise was how much code there is in unbatched_integrators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor license agreement signed docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants