-
Couldn't load subscription status.
- Fork 56
Orbv3 Updates #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orbv3 Updates #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One nit - I think that the code about "direct_stress" and "direct_forces" might be better to remove because it doesn't get triggered for the v3 models?
|
Good to merge? I am going to mint a v0.2 release soon and this would be nice to include. |
Summary
Adapts the OrbModel with recent changes in OrbCalculator and updates tests with both direct and conservative OrbV3 models.
Checklist
Work-in-progress pull requests are encouraged, but please enable the draft status on your PR.
Before a pull request can be merged, the following items must be checked:
Run ruff on your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit installand a check will be run prior to allowing commits.