Skip to content

Conversation

@orionarcher
Copy link
Collaborator

@orionarcher orionarcher commented Apr 14, 2025

Recreated from #124

Hi everyone and thanks for the great work on the library. Also, let us know if you have feedback on https://github.com/Luthaf/vesin!

Summary

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Numpy docstring format.
    Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install and a check will be run prior to allowing commits.

@cla-bot cla-bot bot added the cla-signed Contributor license agreement signed label Apr 14, 2025
@orionarcher
Copy link
Collaborator Author

@frostedoyster, sorry for all the confusion on this PR! Reopened this, is it good to merge?

@frostedoyster
Copy link
Contributor

Yes, I think it's good! It seems that it might be a good idea to increase the tolerance on graphpes a bit

@orionarcher
Copy link
Collaborator Author

Thank you! Will merge now (again)

It seems that it might be a good idea to increase the tolerance on graphpes a bit

Yep! I have that in #143

@orionarcher orionarcher merged commit 414fead into TorchSim:main Apr 14, 2025
174 of 177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants