-
Notifications
You must be signed in to change notification settings - Fork 55
[BREAKING] Remove higher level model imports #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
given that these changes, don't surface better error messages on failed imports and it looks a bit over-engineered, i suggest we remove the imports in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine removing the imports, can we put [breaking] in the PR title so I can track it in the next changelog?
|
@orionarcher the recommended way to highlight breaking changes in github's auto-generated release notes is to have a |
Summary
Attempt to explore if lazy imports can help with the metatensor import issues.Import errors being suppressed by the try-except-pass caused a misleading error message about
MetatensorModelbeing unimportable. see #178