-
Notifications
You must be signed in to change notification settings - Fork 55
Add Batched vdot to clean up fire implementation #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--------- Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com>
|
@t-reents I attempted to copy the changes you added but appear to have failed to do so as I do not match your results. |
|
Interesting, at first glance it indeed seems to be very similar. Out of curiosity, do you also get better results than the previous version, but different ones compared to mine, or do you not even see any improvement? One thing that I noticed while having a quick look, you also included the transformation of the forces according to the current deformation: However, you don't use and |
|
I saw results very similar to what's currently on main |
|
updating to use forces everywhere wasn't a fix sadly |
|
I will have a more detailed look tomorrow, already dedicated some time for it. I'll also double once again check if there are any additional changes on my side that I didn't properly, but in principle it shouldn't be the case. |
|
Already had a quick look. I can reproduce my results (on my branch, so what I shared should be complete). Moreover, when I just checkout your branch and run the script, I get the same results as on my branch, see attached screenshot. Based on this test, it seems that you reproduce my results, doesn't it? |
|
closing in favor of #203! |

Adds a batched vdot to torch_sim.math