Create py.typed #287
Merged
Create py.typed #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a `py.typed` marker so that libraries using torch-sim as a dependency can get everything type checked. https://peps.python.org/pep-0561/ Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
curtischong
approved these changes
Oct 15, 2025
Collaborator
curtischong
left a comment
curtischong
left a comment
There was a problem hiding this comment.
I also looked to see if we need to explicitly define this inside pyproject.toml, but since we're using uv_build we don't need to.
Collaborator
|
@Andrew-S-Rosen Thanks for the suggestion and contribution! The mace tests failing should be fixed. Unfortunately, the fairchem tests fail because of missing hugging face token which will be fixed soon. Will merge once other tests pass. |
Member
|
I will merge this and then resolve the build issues and fairchem test issues in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
py.typedmarker so that libraries using torch-sim as a dependency can get everything type checked. https://peps.python.org/pep-0561/