Skip FairChem tests on forks due to HF secret. #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
related: facebookresearch/fairchem#1570 |
CompRhys
commented
Oct 18, 2025
| uv pip install -e ".[test,${{ matrix.model.name }}]" --resolution=${{ matrix.version.resolution }} --system | ||
| - name: Run ${{ matrix.model.test_path }} tests | ||
| if: ${{ !contains(matrix.model.name, 'fairchem') || github.event.pull_request.head.repo.fork == false }} |
Member
Author
There was a problem hiding this comment.
The tests show as passing with this change rather than not showing due to being skipped. This isn't ideal.
Collaborator
There was a problem hiding this comment.
How about we set an env variable with the repo in the action and then skip in pytest if the repo isn't TorchSim?
Something like:
- name: Run tests
env:
REPO: ${{ github.repository }}@pytest.mark.skipif(
os.getenv("REPO") != os.getenv("TorchSim/torch-sim"), # or something
reason="Skipping tests for forked PR"
)
def test_fairchem():
Member
Author
There was a problem hiding this comment.
functionally that's the same as this? they will just be skipped in the action and the action will be green? All the fairchem tests rely on HF for the models they use
Member
Author
There was a problem hiding this comment.
show as passing here is about Github UX not pytest
Collaborator
There was a problem hiding this comment.
Ah yeah good point, my mistake.
orionarcher
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Will skip fairchem tests on forks to allow forks to hit merge criteria. This is not a true fix as it skips the tests but it prevents the failures which make end users more likely to ignore other test issues.
Checklist
Before a pull request can be merged, the following items must be checked:
We highly recommended installing the
prekhooks running in CI locally to speedup the development process. Simply runpip install prek && prek installto install the hooks which will check your code before each commit.