Skip to content

Conversation

@orionarcher
Copy link
Collaborator

@orionarcher orionarcher commented Nov 4, 2025

Summary

A few mix fixes related to the incoming Quacc integration: Quantum-Accelerators/quacc#3005.

Fixes #330

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
  • Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.

prop_calculators: dict[int, dict[str, Callable]]
state_kwargs: dict[str, Any]
metadata: dict[str, str] | None
shape_warned: bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is technically a breaking change. so I'll label it as breaking

Copy link
Collaborator

@curtischong curtischong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay

@curtischong curtischong added the breaking Breaking changes label Nov 4, 2025
@orionarcher orionarcher merged commit b9ae954 into main Nov 5, 2025
135 of 139 checks passed
@orionarcher orionarcher deleted the misc_fixes branch November 5, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation references to init and update functions being returned

3 participants