Skip to content

fix(engineio/ws): remove unecessary panic message when receiving unexpected ws packets#320

Merged
Totodore merged 1 commit intomainfrom
fix-panic-ws-message
May 8, 2024
Merged

fix(engineio/ws): remove unecessary panic message when receiving unexpected ws packets#320
Totodore merged 1 commit intomainfrom
fix-panic-ws-message

Conversation

@Totodore
Copy link
Copy Markdown
Owner

@Totodore Totodore commented May 8, 2024

@Totodore Totodore enabled auto-merge (squash) May 8, 2024 13:25
Comment thread engineioxide/src/transport/ws.rs Fixed
Comment thread engineioxide/src/transport/ws.rs Fixed
Comment thread engineioxide/src/transport/ws.rs Fixed
Comment thread engineioxide/src/transport/ws.rs Fixed
@Totodore Totodore force-pushed the fix-panic-ws-message branch from 8c7641d to f43ae58 Compare May 8, 2024 13:26
@Totodore Totodore linked an issue May 8, 2024 that may be closed by this pull request
@Totodore Totodore added the C-Bug Something isn't working label May 8, 2024
@Totodore Totodore merged commit b9dedf4 into main May 8, 2024
@Totodore Totodore deleted the fix-panic-ws-message branch May 8, 2024 13:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2024

🐰Bencher

ReportWed, May 8, 2024 at 13:27:13 UTC
ProjectSocketioxide
Branchfix-panic-ws-message
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
engineio_packet/decode/Decode packet binary b64➖ (view plot)87.06
engineio_packet/decode/Decode packet message➖ (view plot)45.07
engineio_packet/decode/Decode packet noop➖ (view plot)34.68
engineio_packet/decode/Decode packet ping/pong➖ (view plot)31.00
engineio_packet/decode/Decode packet ping/pong upgrade➖ (view plot)34.57
engineio_packet/encode/Encode packet binary b64➖ (view plot)55.43
engineio_packet/encode/Encode packet message➖ (view plot)30.26
engineio_packet/encode/Encode packet noop➖ (view plot)30.27
engineio_packet/encode/Encode packet open➖ (view plot)294.28
engineio_packet/encode/Encode packet ping/pong➖ (view plot)29.70
engineio_packet/encode/Encode packet ping/pong upgrade➖ (view plot)29.73
extensions/concurrent_get➖ (view plot)28.13
extensions/concurrent_get_inserts➖ (view plot)30.74
extensions/concurrent_inserts➖ (view plot)22.79
socketio_packet/decode/Decode packet ack on /➖ (view plot)273.56
socketio_packet/decode/Decode packet ack on /custom_nsp➖ (view plot)288.87
socketio_packet/decode/Decode packet binary ack (b64) on /➖ (view plot)502.01
socketio_packet/decode/Decode packet binary ack (b64) on /custom_nsp➖ (view plot)509.10
socketio_packet/decode/Decode packet binary event (b64) on /➖ (view plot)567.58
socketio_packet/decode/Decode packet binary event (b64) on /custom_nsp➖ (view plot)575.08
socketio_packet/decode/Decode packet connect on /➖ (view plot)62.23
socketio_packet/decode/Decode packet connect on /custom_nsp➖ (view plot)76.66
socketio_packet/decode/Decode packet event on /➖ (view plot)349.75
socketio_packet/decode/Decode packet event on /custom_nsp➖ (view plot)368.18
socketio_packet/decode/Decode packet event with ack on /➖ (view plot)345.42
socketio_packet/decode/Decode packet event with ack on /custom_nsp➖ (view plot)367.71
socketio_packet/encode/Encode packet ack on /➖ (view plot)125.44
socketio_packet/encode/Encode packet ack on /custom_nsp➖ (view plot)128.83
socketio_packet/encode/Encode packet binary ack (b64) on /➖ (view plot)314.98
socketio_packet/encode/Encode packet binary ack (b64) on /custom_nsp➖ (view plot)316.36
socketio_packet/encode/Encode packet binary event (b64) on /➖ (view plot)387.16
socketio_packet/encode/Encode packet binary event (b64) on /custom_nsp➖ (view plot)408.98
socketio_packet/encode/Encode packet connect on /➖ (view plot)52.28
socketio_packet/encode/Encode packet connect on /custom_nsp➖ (view plot)54.88
socketio_packet/encode/Encode packet event on /➖ (view plot)129.04
socketio_packet/encode/Encode packet event on /custom_nsp➖ (view plot)132.22
socketio_packet/encode/Encode packet event with ack on /➖ (view plot)127.55
socketio_packet/encode/Encode packet event with ack on /custom_nsp➖ (view plot)131.08

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary panic on Message enum match arms

2 participants