Bugfix: reduce worker disconnect cascades #2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This bugfix is based on this section of the RE spec: I'm pointing it out because the user who reported this issue was an AOSP user, although other users may encounter this issue because we were not compliant before. |
Collaborator
Author
|
/build-image |
|
Image built and pushed! |
Collaborator
|
/build-image |
|
Image built and pushed! |
amankrx
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NativeLink uploads outputs concurrently and uses update_with_whole_file, which moves the file into CAS. If two uploads race on the same path, the second one hits NotFound on rename even though the digest is already in CAS. This PR fixes that issue.
Fixes #2092
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
It's being tested by our users and our customers.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is