refactor: use typeof for assembly retrieval #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors how we obtain the executing assembly's file location by replacing reflection-based GetExecutingAssembly() calls with a direct typeof(Program).Assembly reference. This change improves type safety, clarity, and reduces potential runtime ambiguities. - Consider using `typeof(T).Assembly` to get currently executing assembly: The original code used System.Reflection.Assembly.GetExecutingAssembly().Location to locate the assembly at runtime, which relies on reflection and may not clearly indicate which assembly is in use, especially in multi-assembly scenarios. The updated code replaces this with typeof(Program).Assembly.Location, providing an explicit, compile-time validated reference that is easier to understand and maintain. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
This PR removes redundant type declarations in object instantiation by leveraging C# 9's target-typed new expressions to enhance code readability and reduce verbosity. - Type can be dropped from the declaration's RHS when explicitly mentioned in the LHS: The original code declared a FileInfo instance with an explicit type on both sides of the assignment, leading to repetition. We refactored the instantiation to use the target-typed new (i.e., ‘new(...)’), removing the duplicated type information and adhering to modern C# conventions, which streamlines the code. > This Autofix was generated by AI. Please review the change before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how we obtain the executing assembly's file location by replacing reflection-based GetExecutingAssembly() calls with a direct typeof(Program).Assembly reference. This change improves type safety, clarity, and reduces potential runtime ambiguities.
typeof(T).Assemblyto get currently executing assembly: The original code used System.Reflection.Assembly.GetExecutingAssembly().Location to locate the assembly at runtime, which relies on reflection and may not clearly indicate which assembly is in use, especially in multi-assembly scenarios. The updated code replaces this with typeof(Program).Assembly.Location, providing an explicit, compile-time validated reference that is easier to understand and maintain.