refactor: drop redundant types from object instantiations #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors instantiation expressions to use C# 9 target-typed new, removing redundant type specifications on the right-hand side of declarations. These changes streamline the codebase, reduce verbosity, and improve readability. - Type can be dropped from the declaration's RHS when explicitly mentioned in the LHS: DeepSource highlighted numerous cases where the explicit type in expressions like `new HttpClient()` or `new List<Deposit>()` was unnecessary because the variable’s type was already known. All such instantiations have been replaced with the concise `new()` syntax, leveraging compiler type inference and ensuring consistent, modern C# style across the project. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
…embly This PR refactors how we obtain the currently executing assembly path, replacing the use of Assembly.GetExecutingAssembly() with typeof(Program).Assembly for improved clarity and performance. - Consider using `typeof(T).Assembly` to get currently executing assembly: The original code used Assembly.GetExecutingAssembly().Location, which relies on reflection and can be less direct. The change replaces this with `typeof(Program).Assembly.Location`, leveraging compile-time type metadata for clearer intent and potential performance gains. > This Autofix was generated by AI. Please review the change before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors instantiation expressions to use C# 9 target-typed new, removing redundant type specifications on the right-hand side of declarations. These changes streamline the codebase, reduce verbosity, and improve readability.
new HttpClient()ornew List<Deposit>()was unnecessary because the variable’s type was already known. All such instantiations have been replaced with the concisenew()syntax, leveraging compiler type inference and ensuring consistent, modern C# style across the project.