refactor: simplify single-statement lambda expressions #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors multiple lambda expressions that only contain a single statement, converting them from block-bodied forms with braces and explicit return keywords to concise expression-bodied lambdas. Across service registrations, domain logic, and test assertions, redundant braces and return statements have been removed to improve readability and reduce verbosity. - Consider simplifying lambda when its body has a single statement: Many lambdas in service registration (e.g., `AddSingleton<Func<String, String>>`, `AddSingleton<Func<String, Int32, ISubscriptionRepository>>`) and in tests (e.g., `Should.Throw`, `Should.NotThrow`, `Retry.For`) were written with braces wrapping a single return or await call. Each of these has been converted to an expression-bodied lambda, eliminating unnecessary braces and `return`/`async` block syntax. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors multiple lambda expressions that only contain a single statement, converting them from block-bodied forms with braces and explicit return keywords to concise expression-bodied lambdas. Across service registrations, domain logic, and test assertions, redundant braces and return statements have been removed to improve readability and reduce verbosity.
AddSingleton<Func<String, String>>,AddSingleton<Func<String, Int32, ISubscriptionRepository>>) and in tests (e.g.,Should.Throw,Should.NotThrow,Retry.For) were written with braces wrapping a single return or await call. Each of these has been converted to an expression-bodied lambda, eliminating unnecessary braces andreturn/asyncblock syntax.