refactor: drop explicit types on new expressions #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors object instantiations to leverage C# target-typed new expressions, removing redundant type names on the RHS when the type is already declared on the LHS. - Type can be dropped from the declaration's RHS when explicitly mentioned in the LHS: Many instantiations across the codebase used the verbose `new TypeName(...)` syntax even though the variable type was obvious from the left-hand side. All such occurrences—ranging from dictionaries and resolvers to domain events, factories, mocks, repositories, and unit-test setups—have been updated to the concise `new(...)` form. This reduces boilerplate, improves readability, and aligns the code with modern C# best practices. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
This PR removes unused mock variable declarations across multiple test methods to eliminate compiler warnings and improve code clarity. - Variable is declared but not used: Several mock variables (e.g., Mock<IApplicationBuilder> appBuilder and Mock<IDomainEventHandlerResolver> deh) were declared but never utilized in the tests, leading to compiler warnings and unnecessary code bloat. We removed these unused declarations from all affected test methods, consolidating only the necessary mocks. This cleanup streamlines the test setup, reduces noise, and enhances maintainability. > This Autofix was generated by AI. Please review the change before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors object instantiations to leverage C# target-typed new expressions, removing redundant type names on the RHS when the type is already declared on the LHS.
new TypeName(...)syntax even though the variable type was obvious from the left-hand side. All such occurrences—ranging from dictionaries and resolvers to domain events, factories, mocks, repositories, and unit-test setups—have been updated to the concisenew(...)form. This reduces boilerplate, improves readability, and aligns the code with modern C# best practices.