refactor: use equality operator for nullable bool checks #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the authentication check, replacing a null-coalescing default with an explicit boolean comparison for improved readability and intent. - Consider using the equality operators when evaluating `bool?`: The `principal?.Identity?.IsAuthenticated` property was previously unwrapped with `?? false`, potentially conflating `null` and `false` values. By switching to `== true`, the code now explicitly returns true only when the property is true, while treating null or false as false. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the authentication check, replacing a null-coalescing default with an explicit boolean comparison for improved readability and intent.
bool?: Theprincipal?.Identity?.IsAuthenticatedproperty was previously unwrapped with?? false, potentially conflatingnullandfalsevalues. By switching to== true, the code now explicitly returns true only when the property is true, while treating null or false as false.