Skip to content

refactor: remove unused exception variables in catch clauses #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2025
Merged

refactor: remove unused exception variables in catch clauses #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0423dac
refactor: remove unused exception variables in catch clauses
deepsource-autofix[bot] Sep 20, 2025
c82f4fb
Merge branch 'master' into deepsource-autofix-ffb56119
StuartFerguson Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Shared.EventStore/Aggregate/DomainEventFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ public DomainEvent CreateDomainEvent(Guid aggregateId, ResolvedEvent @event)
try{
eventType = TypeMap.GetType(@event.Event.EventType);
}
catch(Exception ex){
// Nothing here
catch(Exception)
{
}

if (eventType == null)
Expand Down
2 changes: 1 addition & 1 deletion Shared.EventStore/Aggregate/TypeMapConvertor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static IDomainEvent Convertor(Guid aggregateId, ResolvedEvent @event)
{
eventType = TypeMap.GetType(@event.Event.EventType);
}
catch (Exception ex)
catch (Exception)
{
// Nothing here
}
Expand Down
2 changes: 1 addition & 1 deletion Shared.IntegrationTesting/BaseDockerHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@
connection.Close();
this.Trace("SQL Server Container Running");
}
catch(SqlException ex){
catch(SqlException){
if (connection.State == ConnectionState.Open){
connection.Close();
}
Expand Down Expand Up @@ -859,7 +859,7 @@
try{
await projectionClient.CreateContinuousAsync(projectionName, projection, trackEmittedStreams:true).ConfigureAwait(false);
}
catch(Exception ex){

Check warning on line 862 in Shared.IntegrationTesting/BaseDockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests - Linux 

The variable 'ex' is declared but never used

Check warning on line 862 in Shared.IntegrationTesting/BaseDockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests - Windows 

The variable 'ex' is declared but never used
}

projectionNames.Add(projectionName);
Expand Down
4 changes: 2 additions & 2 deletions Shared/Extensions/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ public static Boolean TryParseJson<T>(this String obj, out T result)
result = JsonConvert.DeserializeObject<T>(obj, settings);
return true;
}
catch (JsonReaderException jrex)
catch (JsonReaderException)
{
result = default(T);
return false;
}
catch (JsonSerializationException jsex)
catch (JsonSerializationException)
{
result = default(T);
return false;
Expand Down
2 changes: 1 addition & 1 deletion Shared/General/ConfigurationReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static T GetValueOrDefault<T>(String sectionName, String keyName, T defau

return (T)Convert.ChangeType(value, typeof(T));
}
catch (KeyNotFoundException kex)
catch (KeyNotFoundException)
{
return defaultValue;
}
Expand Down
Loading