Skip to content

refactor: simplify single-statement lambdas #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2025
Merged

refactor: simplify single-statement lambdas #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Shared.EventStore.Tests/ApplicationBuilderExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void ApplicationBuilderExtensions_ConfigureSubscriptions_WorkerListReturn
eventHandlerResolvers.Add("Ordered", deh.Object);
eventHandlerResolvers.Add("Main", deh.Object);
eventHandlerResolvers.Add("Domain", deh.Object);
Action<TraceEventType, String, String> traceHandler = (et, type, msg)=> { TestOutputHelper.WriteLine(msg); };
Action<TraceEventType, String, String> traceHandler = (et, type, msg) => TestOutputHelper.WriteLine(msg);
var result = IApplicationBuilderExtenstions.ConfigureSubscriptions(subscriptionRepository.Object, config,
eventStoreConnectionString, eventHandlerResolvers, traceHandler);
result.Count.ShouldBe(3);
Expand Down Expand Up @@ -185,7 +185,7 @@ public void ApplicationBuilderExtensions_ConfigureSubscriptions_MainOnlyWorkers_
String eventStoreConnectionString = "esdb://192.168.0.133:2113?tls=true&tlsVerifyCert=false";
Dictionary<String, IDomainEventHandlerResolver> eventHandlerResolvers = new();
eventHandlerResolvers.Add("Main", deh.Object);
Action<TraceEventType, String, String> traceHandler = (et, type, msg) => { TestOutputHelper.WriteLine(msg); };
Action<TraceEventType, String, String> traceHandler = (et, type, msg) => TestOutputHelper.WriteLine(msg);
var result = IApplicationBuilderExtenstions.ConfigureSubscriptions(subscriptionRepository.Object, config,
eventStoreConnectionString, eventHandlerResolvers, traceHandler);
result.Count.ShouldBe(1);
Expand Down Expand Up @@ -240,7 +240,7 @@ public void ApplicationBuilderExtensions_ConfigureSubscriptions_MainOnlyWorkers_
String eventStoreConnectionString = "esdb://192.168.0.133:2113?tls=true&tlsVerifyCert=false";
Dictionary<String, IDomainEventHandlerResolver> eventHandlerResolvers = new();
eventHandlerResolvers.Add("Main", deh.Object);
Action<TraceEventType, String, String> traceHandler = (et, type, msg) => { TestOutputHelper.WriteLine(msg); };
Action<TraceEventType, String, String> traceHandler = (et, type, msg) => TestOutputHelper.WriteLine(msg);
var result = IApplicationBuilderExtenstions.ConfigureSubscriptions(subscriptionRepository.Object, config,
eventStoreConnectionString, eventHandlerResolvers, traceHandler);
result.Count.ShouldBe(2);
Expand Down
7 changes: 1 addition & 6 deletions Shared.EventStore/Aggregate/AggregateMemoryCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,7 @@ public void Set<TAggregate>(String key,
if (!AggregateMemoryCache.CallbackRegistered.TryGetValue(aggregateType, out isRegistered) || !isRegistered) // Double-check locking
{
// Register a callback to remove the item from our internal tracking
memoryCacheEntryOptions.RegisterPostEvictionCallback((evictedKey,
_,
_,
_) => {
this.KeyTracker.TryRemove(evictedKey.ToString(), out _);
});
memoryCacheEntryOptions.RegisterPostEvictionCallback((evictedKey, _, _, _) => this.KeyTracker.TryRemove(evictedKey.ToString(), out _));

AggregateMemoryCache.CallbackRegistered[aggregateType] = true;
}
Expand Down
2 changes: 1 addition & 1 deletion Shared.Tests/ClientProxyBaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public async Task ClientProxyBase_HandleResponse_SuccessStatus(HttpStatusCode st
HttpResponseMessage response = new(statusCode);
response.Content = new StringContent(responseContent);
TestClient proxybase = new(new HttpClient());
Should.NotThrow(async () => { await proxybase.Test_HandleResponse(response, CancellationToken.None); });
Should.NotThrow(async () => await proxybase.Test_HandleResponse(response, CancellationToken.None));
}

[Theory]
Expand Down
Loading