Skip to content

Dont calculate fees for Verify Account transactions #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Dont calculate fees for Verify Account transactions #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions TransactionProcessor.BusinessLogic/EventHandling/TransactionDomainEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,21 +142,25 @@ private async Task<TokenResponse> GetToken(CancellationToken cancellationToken)
return this.TokenResponse;
}

private Boolean RequireFeeCalculation(TransactionAggregate transactionAggregate){
return transactionAggregate switch{
_ when transactionAggregate.IsAuthorised == false => false,
_ when transactionAggregate.IsCompleted == false => false,
_ when transactionAggregate.TransactionType == TransactionType.Logon => false,
_ when transactionAggregate.ContractId == Guid.Empty => false,
_ when transactionAggregate.ProductId == Guid.Empty => false,
_ when transactionAggregate.TransactionAmount == null => false,
_ => true
};
}

private async Task HandleSpecificDomainEvent(TransactionHasBeenCompletedEvent domainEvent,
CancellationToken cancellationToken) {
TransactionAggregate transactionAggregate =
await this.TransactionAggregateRepository.GetLatestVersion(domainEvent.TransactionId, cancellationToken);

if (transactionAggregate.IsAuthorised == false) {
// Ignore not successful transactions
return;
}

if (transactionAggregate.IsCompleted == false || transactionAggregate.TransactionType == TransactionType.Logon ||
(transactionAggregate.ContractId == Guid.Empty || transactionAggregate.ProductId == Guid.Empty)) {
// These transactions cannot have fee values calculated so skip
if (RequireFeeCalculation(transactionAggregate) == false)
return;
}

this.TokenResponse = await this.GetToken(cancellationToken);

Expand Down