Skip to content

voucher domain service refactored #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

voucher domain service refactored #862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
787e927
voucher domain service refactored
StuartFerguson Aug 19, 2025
1528c0c
oops
StuartFerguson Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 65 additions & 90 deletions TransactionProcessor.BusinessLogic/Services/VoucherDomainService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace TransactionProcessor.BusinessLogic.Services;
using Microsoft.EntityFrameworkCore;
using Models;
using NetBarcode;
using Shared.DomainDrivenDesign.EventSourcing;
using Shared.EntityFramework;
using Shared.EventStore.Aggregate;
using Shared.Exceptions;
Expand Down Expand Up @@ -69,9 +68,7 @@ public class VoucherDomainService : IVoucherDomainService
private static readonly String EstateManagementDatabaseName = "TransactionProcessorReadModel";

private readonly IAggregateService AggregateService;

private const String ConnectionStringIdentifier = "EstateReportingReadModel";


#region Constructors

public VoucherDomainService(Func<IAggregateService> aggregateService,
Expand All @@ -83,107 +80,86 @@ public VoucherDomainService(Func<IAggregateService> aggregateService,
#endregion

#region Methods

private async Task<Result<T>> ApplyUpdates<T>(Func<VoucherAggregate, Task<Result<T>>> action,
Guid voucherId,
CancellationToken cancellationToken,
Boolean isNotFoundError = true)
{
try
{
Result<VoucherAggregate> getVoucherResult = await this.AggregateService.GetLatest<VoucherAggregate>(voucherId, cancellationToken);
Result<VoucherAggregate> voucherAggregateResult =
DomainServiceHelper.HandleGetAggregateResult(getVoucherResult, voucherId, isNotFoundError);

if (voucherAggregateResult.IsFailed)
return ResultHelpers.CreateFailure(voucherAggregateResult);

VoucherAggregate voucherAggregate = voucherAggregateResult.Data;
Result<T> result = await action(voucherAggregate);
if (result.IsFailed)
return ResultHelpers.CreateFailure(result);

Result saveResult = await this.AggregateService.Save(voucherAggregate, cancellationToken);
if (saveResult.IsFailed)
return ResultHelpers.CreateFailure(saveResult);
return Result.Success(result.Data);
}
catch (Exception ex)
{
return Result.Failure(ex.GetExceptionMessages());
}
}


public async Task<Result<IssueVoucherResponse>> IssueVoucher(Guid voucherId, Guid operatorId, Guid estateId,
Guid transactionId,
DateTime issuedDateTime,
Decimal value,
String recipientEmail, String recipientMobile, CancellationToken cancellationToken) {
Result<IssueVoucherResponse> result = await ApplyUpdates<IssueVoucherResponse>(
async (VoucherAggregate voucherAggregate) => {
try{
Result<EstateResponse> validateResult = await this.ValidateVoucherIssue(estateId, operatorId, cancellationToken);
if (validateResult.IsFailed)
return ResultHelpers.CreateFailure(validateResult);

Result<EstateResponse> validateResult = await this.ValidateVoucherIssue(estateId, operatorId, cancellationToken);
if (validateResult.IsFailed)
return ResultHelpers.CreateFailure(validateResult);
Result<VoucherAggregate> voucherResult = await DomainServiceHelper.GetAggregateOrFailure(ct => this.AggregateService.GetLatest<VoucherAggregate>(voucherId, ct), voucherId, cancellationToken, false);
if (voucherResult.IsFailed)
return ResultHelpers.CreateFailure(voucherResult);

voucherAggregate.Generate(operatorId, estateId, transactionId, issuedDateTime, value);
VoucherAggregate voucherAggregate = voucherResult.Data;

Models.Voucher voucherModel = voucherAggregate.GetVoucher();
voucherAggregate.Generate(operatorId, estateId, transactionId, issuedDateTime, value);

// Generate the barcode
Barcode barcode = new Barcode(voucherModel.VoucherCode);
voucherAggregate.AddBarcode(barcode.GetBase64Image());
voucherAggregate.Issue(recipientEmail, recipientMobile, issuedDateTime);
Models.Voucher voucherModel = voucherAggregate.GetVoucher();

return Result.Success(new IssueVoucherResponse
{
ExpiryDate = voucherModel.ExpiryDate,
Message = voucherModel.Message,
VoucherCode = voucherModel.VoucherCode,
VoucherId = voucherId
});
// Generate the barcode
Barcode barcode = new Barcode(voucherModel.VoucherCode);
voucherAggregate.AddBarcode(barcode.GetBase64Image());
voucherAggregate.Issue(recipientEmail, recipientMobile, issuedDateTime);

}, voucherId, cancellationToken, false);
Result saveResult = await this.AggregateService.Save(voucherAggregate, cancellationToken);
if (saveResult.IsFailed)
return ResultHelpers.CreateFailure(saveResult);

return result;
return Result.Success(new IssueVoucherResponse
{
ExpiryDate = voucherModel.ExpiryDate,
Message = voucherModel.Message,
VoucherCode = voucherModel.VoucherCode,
VoucherId = voucherId
});
}
catch (Exception ex)
{
return Result.Failure(ex.GetExceptionMessages());
}
}

/// <summary>
/// Redeems the voucher.
/// </summary>
/// <param name="estateId">The estate identifier.</param>
/// <param name="voucherCode">The voucher code.</param>
/// <param name="redeemedDateTime">The redeemed date time.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns></returns>
/// <exception cref="NotFoundException">No voucher found with voucher code [{voucherCode}]</exception>
public async Task<Result<RedeemVoucherResponse>> RedeemVoucher(Guid estateId,
String voucherCode,
DateTime redeemedDateTime,
CancellationToken cancellationToken)
{
// Find the voucher based on the voucher code
using ResolvedDbContext<EstateManagementContext>? resolvedContext = this.Resolver.Resolve(EstateManagementDatabaseName, estateId.ToString());
await using EstateManagementContext context = resolvedContext.Context;
try
{
// Find the voucher based on the voucher code
using ResolvedDbContext<EstateManagementContext>? resolvedContext = this.Resolver.Resolve(EstateManagementDatabaseName, estateId.ToString());
await using EstateManagementContext context = resolvedContext.Context;

TransactionProcessor.Database.Entities.VoucherProjectionState voucher = await context.VoucherProjectionStates.SingleOrDefaultAsync(v => v.VoucherCode == voucherCode, cancellationToken);
TransactionProcessor.Database.Entities.VoucherProjectionState voucher = await context.VoucherProjectionStates.SingleOrDefaultAsync(v => v.VoucherCode == voucherCode, cancellationToken);

if (voucher == null)
{
return Result.NotFound($"No voucher found with voucher code [{voucherCode}]");
}
if (voucher == null)
{
return Result.NotFound($"No voucher found with voucher code [{voucherCode}]");
}

Result<RedeemVoucherResponse> result = await ApplyUpdates<RedeemVoucherResponse>(
async (VoucherAggregate voucherAggregate) => {
Result<EstateResponse> validateResult = await this.ValidateVoucherRedemption(estateId, cancellationToken);
if (validateResult.IsFailed)
return ResultHelpers.CreateFailure(validateResult);




Result<VoucherAggregate> voucherResult = await DomainServiceHelper.GetAggregateOrFailure(ct => this.AggregateService.GetLatest<VoucherAggregate>(voucher.VoucherId, ct), voucher.VoucherId, cancellationToken);
if (voucherResult.IsFailed)
return ResultHelpers.CreateFailure(voucherResult);

VoucherAggregate voucherAggregate = voucherResult.Data;

// Redeem the voucher
voucherAggregate.Redeem(redeemedDateTime);

// Save the changes
await this.AggregateService.Save(voucherAggregate, cancellationToken);
Result saveResult = await this.AggregateService.Save(voucherAggregate, cancellationToken);
if (saveResult.IsFailed)
return ResultHelpers.CreateFailure(saveResult);

Models.Voucher voucherModel = voucherAggregate.GetVoucher();

Expand All @@ -194,21 +170,21 @@ public async Task<Result<RedeemVoucherResponse>> RedeemVoucher(Guid estateId,
VoucherCode = voucherModel.VoucherCode
});

}, voucher.VoucherId, cancellationToken);

return result;
}
catch (Exception ex)
{
return Result.Failure(ex.GetExceptionMessages());
}
}


private async Task<Result> ValidateVoucherIssue(Guid estateId, Guid operatorId, CancellationToken cancellationToken)
{
// Validate the Estate Record is a valid estate
Result<EstateAggregate> getEstateResult = await this.AggregateService.Get<EstateAggregate>(estateId, cancellationToken);
if (getEstateResult.IsFailed)
{
return ResultHelpers.CreateFailure(getEstateResult);
}
EstateAggregate estateAggregate = getEstateResult.Data;
Result<EstateAggregate> estateResult = await DomainServiceHelper.GetAggregateOrFailure(ct => this.AggregateService.Get<EstateAggregate>(estateId, ct), estateId, cancellationToken);
if (estateResult.IsFailed)
return ResultHelpers.CreateFailure(estateResult);
EstateAggregate estateAggregate = estateResult.Data;

Estate estate = estateAggregate.GetEstate();
if (estate.Operators == null || estate.Operators.Any() == false)
Expand All @@ -228,10 +204,9 @@ private async Task<Result> ValidateVoucherIssue(Guid estateId, Guid operatorId,
private async Task<Result> ValidateVoucherRedemption(Guid estateId, CancellationToken cancellationToken)
{
// Validate the Estate Record is a valid estate
Result<EstateAggregate> getEstateResult = await this.AggregateService.Get<EstateAggregate>(estateId, cancellationToken);
if (getEstateResult.IsFailed) {
return ResultHelpers.CreateFailure(getEstateResult);
}
Result<EstateAggregate> estateResult = await DomainServiceHelper.GetAggregateOrFailure(ct => this.AggregateService.Get<EstateAggregate>(estateId, ct), estateId, cancellationToken);
if (estateResult.IsFailed)
return ResultHelpers.CreateFailure(estateResult);

return Result.Success();
}
Expand Down
Loading