Refactor settlement service and update tests #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted expected calls to Save method in SettlementDomainServiceTests. Refactored error handling and reduced code duplication in SettlementDomainService methods. Improved robustness of aggregate retrieval and ensured consistent result handling in AddMerchantFeePendingSettlement and AddSettledFeeToSettlement.
github-actions
bot
deleted the
task/#856_settlement_domain_service_performance_tweaks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted expected calls to Save method in SettlementDomainServiceTests.
Refactored error handling and reduced code duplication in SettlementDomainService methods.
Improved robustness of aggregate retrieval and ensured consistent result handling in AddMerchantFeePendingSettlement and AddSettledFeeToSettlement.
closes #856