Skip to content

handle retries on TransactionHasBeenCompletedEvent #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

handle retries on TransactionHasBeenCompletedEvent #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ...essor.BusinessLogic.Tests/DomainEventHandlers/MerchantStatementDomainEventHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,37 @@
result.IsSuccess.ShouldBeTrue();
}

[Fact]
public async Task MerchantStatementDomainEventHandler_Handle_TransactionHasBeenCompletedEvent_WrongExpectedRetried_EventIsHandled()
{
List<String> errors = new() { "WrongExpectedVersion" };

Check warning on line 61 in TransactionProcessor.BusinessLogic.Tests/DomainEventHandlers/MerchantStatementDomainEventHandlerTests.cs

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

TransactionProcessor.BusinessLogic.Tests/DomainEventHandlers/MerchantStatementDomainEventHandlerTests.cs#L61 

Define a constant instead of using this literal 'WrongExpectedVersion' 4 times.

this.Mediator.SetupSequence(m => m.Send(It.IsAny<IRequest<Result>>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure(errors))
.ReturnsAsync(Result.Success());

Result result = await this.EventHandler.Handle(TestData.DomainEvents.TransactionHasBeenCompletedEvent, CancellationToken.None);
result.IsSuccess.ShouldBeTrue();
this.Mediator.Verify(m => m.Send(It.IsAny<IRequest<Result>>(), It.IsAny<CancellationToken>()), Times.Exactly(2));
}

[Fact]
public async Task MerchantStatementDomainEventHandler_Handle_TransactionHasBeenCompletedEvent_WrongExpectedRetried_AllRetriesFailed()
{
List<String> errors = new() { "WrongExpectedVersion" };
this.Mediator.SetupSequence(m => m.Send(It.IsAny<IRequest<Result>>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure(errors))
.ReturnsAsync(Result.Failure(errors))
.ReturnsAsync(Result.Failure(errors))
.ReturnsAsync(Result.Failure(errors))
.ReturnsAsync(Result.Failure(errors))
.ReturnsAsync(Result.Failure(errors));

Result result = await this.EventHandler.Handle(TestData.DomainEvents.TransactionHasBeenCompletedEvent, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
this.Mediator.Verify(m => m.Send(It.IsAny<IRequest<Result>>(), It.IsAny<CancellationToken>()), Times.Exactly(6));
}

[Fact]
public async Task MerchantStatementDomainEventHandler_Handle_MerchantFeeSettledEvent_EventIsHandled()
{
Expand Down
29 changes: 17 additions & 12 deletions TransactionProcessor.BusinessLogic/EventHandling/MerchantStatementDomainEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,24 @@ private async Task<Result> HandleSpecificDomainEvent(MerchantStatementDomainEven

private async Task<Result> HandleSpecificDomainEvent(TransactionDomainEvents.TransactionHasBeenCompletedEvent domainEvent,
CancellationToken cancellationToken) {
MerchantStatementCommands.AddTransactionToMerchantStatementCommand command = new(domainEvent.EstateId, domainEvent.MerchantId, domainEvent.CompletedDateTime,
Money.Create(domainEvent.TransactionAmount.GetValueOrDefault(0)), domainEvent.IsAuthorised, domainEvent.TransactionId);
IAsyncPolicy<Result> retryPolicy = PolicyFactory.CreatePolicy(policyTag: "MerchantStatementDomainEventHandler - HandleSpecificDomainEvent<SettlementDomainEvents.TransactionHasBeenCompletedEvent>");

Result result = await this.Mediator.Send(command, cancellationToken);
return result;
try
{
return await PolicyFactory.ExecuteWithPolicyAsync(async () =>
{
MerchantStatementCommands.AddTransactionToMerchantStatementCommand command = new(domainEvent.EstateId, domainEvent.MerchantId, domainEvent.CompletedDateTime,
Money.Create(domainEvent.TransactionAmount.GetValueOrDefault(0)), domainEvent.IsAuthorised, domainEvent.TransactionId);

Result result = await this.Mediator.Send(command, cancellationToken);
return result;

}, retryPolicy, "MerchantStatementDomainEventHandler - HandleSpecificDomainEvent<SettlementDomainEvents.TransactionHasBeenCompletedEvent>");
}
catch (Exception ex)
{
return Result.Failure(ex.GetExceptionMessages());
}
}

private async Task<Result> HandleSpecificDomainEvent(MerchantDomainEvents.AutomaticDepositMadeEvent domainEvent,
Expand Down Expand Up @@ -163,14 +176,6 @@ private async Task<Result> HandleSpecificDomainEvent(SettlementDomainEvents.Merc
{
return Result.Failure(ex.GetExceptionMessages());
}
//MerchantStatementCommands.AddSettledFeeToMerchantStatementCommand command = new(domainEvent.EstateId, domainEvent.MerchantId, domainEvent.FeeCalculatedDateTime,
// PositiveMoney.Create(Money.Create(domainEvent.CalculatedValue)), domainEvent.TransactionId, domainEvent.FeeId);

////return await this.Mediator.Send(command, cancellationToken);
//Result result = await this.Mediator.Send(command, cancellationToken);
//return result;


}

#endregion
Expand Down
Loading