Support loading/patching Transit itinerary_cells.txt format #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2025
n8han
approved these changes
Oct 28, 2025
n8han
left a comment
n8han
left a comment
There was a problem hiding this comment.
lgtm at the code level, and the integration with the existing functionality as well
|
|
||
|
|
||
| def do_test(feed_dir): | ||
| itineraries = 'itineraries' in feed_dir.name |
There was a problem hiding this comment.
This seems very strange to me, but after a read thru of test_support.py I see it does follow existing code in terms of meaningful directory names. The approach established there of a single do_test function all tests doesn't scale well but 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading/writing to
itinerary_cells.txtand the trips schema that comes with. This is used internally by Transit in its data-processing pipeline for efficiency.New minor version that can be consumed by other projects that depend on these binding, such as GTFS-Flex-to-GOFS-lite and GTFS-blocks-to-transfers.