Skip to content

Conversation

@imranhsayed
Copy link
Contributor

@imranhsayed imranhsayed commented Feb 7, 2024

  • The disabled attribute was not working in the case of the nested slider because since querySelector was used it would find the first instance of the arrow which was from the inner slider instead of parent slider arrow.
  • This PR fixes that issue by checking if the parent tp-slider of the arrow element is same as this. If it is then that means we have found the correct arrow element.
  • we cannot use CSS for this because the user can keep the arrows anywhere they want.
image image

@junaidbhura junaidbhura merged commit 0a2a90a into master Feb 8, 2024
@junaidbhura junaidbhura deleted the fix/slider-arrows branch February 8, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants