Skip to content

Fix Multi Select Event Conflict #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix Multi Select Event Conflict #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/multi-select/tp-multi-select-search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,15 @@ export class TPMultiSelectSearchElement extends HTMLElement {
* @param {Event} e Click event.
*/
protected handleClick( e: Event ): void {
// First, prevent propagation to avoid document.click set on `tp-multi-select`.
e.preventDefault();
e.stopPropagation();

// Now send the event so other stuff can work as per normal, and another event for good measure.
this.dispatchEvent( new CustomEvent( 'multi-select-opened' ) );
document.dispatchEvent( new Event( 'click' ) );

// Open multi select.
this.closest( 'tp-multi-select' )?.setAttribute( 'open', 'yes' );
}

Expand Down