Skip to content

Fix: Multi-Select - Allow unique pills incase of duplicate values #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix: Multi-Select - Allow unique pills incase of duplicate values #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b4e2f9
fix: Allow only unique pills
Takshil-Kunadia Oct 24, 2024
a22976d
fix: remove spacing in options
Takshil-Kunadia Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/multi-select/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
}

tp-multi-select-option + tp-multi-select-option {
border-top: 1px solid #000;
background-color: gainsboro;
}

tp-multi-select-select-all[selected="yes"]::after,
Expand Down Expand Up @@ -97,14 +97,18 @@
</tp-multi-select-search>
</tp-multi-select-field>
<tp-multi-select-options>
<tp-multi-select-select-all select-text="Select All" unselect-text="Un-Select All">Select All</tp-multi-select-select-all>
<tp-multi-select-option value="priya" label="Priya">Priya</tp-multi-select-option>
<tp-multi-select-option value="varun" label="Varun">Varun</tp-multi-select-option>
<tp-multi-select-option value="john" label="John">John</tp-multi-select-option>
<tp-multi-select-option value="jane" label="Jane">Jane</tp-multi-select-option>
<tp-multi-select-option value="jack" label="Jack">Jack</tp-multi-select-option>
<tp-multi-select-option value="jill" label="Jill" disabled="yes">Jill</tp-multi-select-option>
</tp-multi-select-options>
<div>
<div>Most Popular</div>
<tp-multi-select-option value="Japan" label="Japan">Japan</tp-multi-select-option>
<tp-multi-select-option value="Maldiverna" label="Maldiverna">Maldiverna</tp-multi-select-option>
<tp-multi-select-option value="USA" label="USA">USA</tp-multi-select-option>
</div>
<div>
<div>Asia</div>
<tp-multi-select-option value="Japan" label="Japan">Japan</tp-multi-select-option>
<tp-multi-select-option value="India" label="India">India</tp-multi-select-option>
</div>
</tp-multi-select-options>
</tp-multi-select>
</main>
</body>
Expand Down
2 changes: 1 addition & 1 deletion src/multi-select/tp-multi-select-pills.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class TPMultiSelectPillsElement extends HTMLElement {

// Determine pills.
const pills: NodeListOf<TPMultiSelectPillElement> | null = this.querySelectorAll( 'tp-multi-select-pill' );
const values: string[] = multiSelect.value ?? [];
const values: string[] = [ ...new Set( multiSelect.value ) ] ?? [];
const pillValues: string[] = [];

// Remove pills that shouldn't exist.
Expand Down
Loading