fix(core,github-action): set git user before release flows#155
Merged
Conversation
Coverage Report for CI Build 28392337989Coverage increased (+1.0%) to 64.006%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an explicit setUser step to configure git user identity as part of the release pipeline, and wires it into the GitHub Action’s default flows so commits/tags are attributed correctly.
Changes:
- Added
Releaser.setUser()step in@simple-release/coreand correspondingReleaserSetUserOptionstype + step options wiring. - Removed git user configuration from
checkout()and added a core unit test coveringsetUser. - Updated the GitHub Action releaser to default to
github-actions[bot]and documented the updated default flows.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/github-action/src/releaser.ts | Adds setUser() override/defaults and calls it in the action’s PR/release flows. |
| packages/github-action/README.md | Documents default action flows, now including setUser(). |
| packages/core/src/releaser.types.ts | Introduces ReleaserSetUserOptions and adds stepsOptions.setUser. |
| packages/core/src/releaser.ts | Adds setUser() step and removes user config from checkout(). |
| packages/core/src/releaser.spec.ts | Adds a unit test verifying setUser() writes git config values. |
| packages/core/README.md | Adds setUser to the list of available steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
131
to
135
| await this | ||
| .setUser() | ||
| .checkout() | ||
| .fetchOptions() | ||
| .bump() |
Comment on lines
+41
to
+45
| return super.setUser({ | ||
| username: 'github-actions[bot]', | ||
| email: 'github-actions[bot]@users.noreply.github.com', | ||
| ...options | ||
| }) |
Comment on lines
149
to
153
| action | ||
| .setUser() | ||
| .checkout() | ||
| .fetchOptions() | ||
| .bump() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.