Admonitions have wrong icon/logo

[meichthys]

Description

I've been really enjoying the new admonitions feature, however I've noticed that the warning and caution admonitions seem to have non-intuative icons/colors:

Generally caution is associated with yellow and the caution sign, while warnings are associated with red and the error symbol.

Perhaps this is an upstream issue with CKEditor, if so, feel free to close this.

TriliumNext Version

0.92.4

What operating system are you using?

Windows

What is your setup?

Local (no sync)

Operating System Version

Windows 11

Error logs

No response

[eliandoran]

@meichthys , the admonitions are at 1:1 parity (colors, types of admonitions, icons, even Markdown import/export) with GitHub's admonitions support, as documented here: https://github.blog/changelog/2023-12-14-new-markdown-extension-alerts-provide-distinctive-styling-for-significant-content/

The admonitions are pretty configurable via CSS:

.admonition.note { --accent-color: #69c7ff; }
.admonition.tip { --accent-color: #40c025; }
.admonition.important { --accent-color: #9839f7; }
.admonition.caution { --accent-color: #ff2e2e; }
.admonition.warning { --accent-color: #e2aa03; }

If you need to switch the icons as well, you can use the following reference:

.admonition.note::before { content: "\eb21"; }
.admonition.tip::before { content: "\ea0d"; }
.admonition.important::before { content: "\ea7c"; }
.admonition.caution::before { content: "\eac7"; }
.admonition.warning::before { content: "\eac5"; }

---

In your case you could create an #appCss note with the following content:

.admonition.warning { --accent-color: #ff2e2e !important; }
.admonition.caution { --accent-color: #e2aa03 !important; }
.admonition.warning::before { content: "\eac7" !important; }
.admonition.caution::before { content: "\eac5" !important; }

Perhaps this is an upstream issue with CKEditor, if so, feel free to close this.

Actually not, the admonitions are a feature exclusively implemented by us, as a custom plugin. 💪🏻

[meichthys]

Wow thanks. I didn't know that! I guess I just have it backward then lol
I guess there's a few others that agree, but it's best to stick with the github standard since that's what most people would probably be familiar with.
github/markup#1865