This repository was archived by the owner on Jun 24, 2025. It is now read-only.
Allow the Tab row scroll #1700
Merged
Allow the Tab row scroll #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eliandoran
suggested changes
Apr 14, 2025
Contributor
eliandoran
left a comment
eliandoran
left a comment
There was a problem hiding this comment.
Pretty good work. :)
However, it seems that on the horizontal layout, the tabs are missing one pixel in height at the top which makes the tab appear slightly cut off (can be seen with the naked eye, albeit a little bit more difficult). At the bottom there is also a "half-pixel" border on the active tab, which there shouldn't be.
This happens on Firefox 137.
Before:
After:
eliandoran
suggested changes
Apr 15, 2025
Contributor
eliandoran
left a comment
eliandoran
left a comment
There was a problem hiding this comment.
Using a laptop's touch pad on Windows on Electron seems that tapping on a tab to select it no longer works, you have to double-tab.
eliandoran
approved these changes
Apr 15, 2025
dosubot
bot
added
the
size:L
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to TriliumNext/Trilium#5594