Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Conversation

@pano9000
Copy link
Contributor

@pano9000 pano9000 commented Apr 15, 2025

this PR adds some initial, basic tests for the login route — it does not cover every case yet, but we have a start now at least

@github-actions
Copy link

github-actions bot commented Apr 15, 2025

Folder/File Previous size New size Difference
/upload/TriliumNextNotes-Server-1711-merge-linux-x64.tar.xz 85.17MB +85.17MB (+100.00%)
TOTAL +85.17MB

@github-actions
Copy link

github-actions bot commented Apr 15, 2025

Folder/File Previous size New size Difference
/upload/TriliumNextNotes-1711-merge-linux-x64.deb 137.77MB +137.77MB (+100.00%)
/upload/TriliumNextNotes-1711-merge-linux-x64.flatpak 130.87MB +130.87MB (+100.00%)
/upload/TriliumNextNotes-1711-merge-linux-x64.rpm 145.79MB +145.79MB (+100.00%)
/upload/TriliumNextNotes-1711-merge-linux-x64.zip 176.7MB +176.7MB (+100.00%)
TOTAL +591.13MB

@pano9000
Copy link
Contributor Author

(tests currently fail of course, as long as the other "login" related PRs are not merged)

@pano9000 pano9000 force-pushed the test_add-login-route-tests branch 3 times, most recently from bac50dc to 608fdd7 Compare April 16, 2025 08:06
@pano9000 pano9000 marked this pull request as ready for review April 16, 2025 08:07
@pano9000
Copy link
Contributor Author

hmm, the test is failing in CI with

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/routes/login.spec.ts > Login Route test > does not set Expires, when 'Remember Me' is not ticked
Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

but runs through perfectly fine locally.

will need to have a closer look this evening again

@pano9000 pano9000 marked this pull request as draft April 16, 2025 08:11
@eliandoran eliandoran added this to the v0.93.0 milestone Apr 17, 2025
@pano9000 pano9000 force-pushed the test_add-login-route-tests branch from 608fdd7 to a149b56 Compare April 17, 2025 20:59
@pano9000 pano9000 marked this pull request as ready for review April 17, 2025 21:01
@eliandoran eliandoran merged commit 2e8ab7e into develop Apr 17, 2025
8 checks passed
@eliandoran eliandoran deleted the test_add-login-route-tests branch April 17, 2025 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants