This repository was archived by the owner on Jun 24, 2025. It is now read-only.
fix(find): readonly code getSelection #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eliandoran
suggested changes
May 14, 2025
apps/client/src/widgets/find.ts
Outdated
| const codeEditor = await this.noteContext.getCodeEditor(); | ||
| selectedText = codeEditor.getSelectedText(); | ||
| } | ||
| if (this.note?.type === "code" && this.noteContext && !isReadOnly) { |
Contributor
There was a problem hiding this comment.
Now we have getCodeEditor for read-only code notes as well (not sure why it wasn't the case in upstream Trilium), so I guess we could remove the read-only check entirely.
Member
Author
There was a problem hiding this comment.
I tried it and it really works. It seems that you have fixed the issue. , I remembered that the codeEditor would not be fetched inside the read-only code before so that's why the check was there.
eliandoran
approved these changes
May 14, 2025
eliandoran
added a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In read-only code, the selected text can be directly obtained through getSelection