(Unit testing) using Karma test runner #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest changes from base fork
Merge latest changes from master repo
Contributor
Author
|
Ideas borrowed from
|
Member
|
This is fantastic! Yeah I think ideally we might as well stick with the default as Jest doesn't offer the same type of testing. I'll move the Jest stuff into a HOW TO PR, for others to see at least! 👍👍🍻🍻 |
MarkPieszak
approved these changes
Sep 4, 2017
Contributor
|
I deleted ngx-bootstrap from my app. Do I need to worry about this? Is this a bigger issue or is this PR just to fix testing ngx-bootstrap modal testing? |
Contributor
|
@davidsekar @MarkPieszak Is this something I need to be pulling in? Or just an issue with testing ngx-bootstrap which I don't use in my app |
Member
|
It's up to you, this is just if you want the traditional way Karma does testing (with a browser) as opposed to Jest, which can't do that. @jrmcdona |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on reply in Angular CLI project project thread.
Feature request: Support using Jest testing framework angular/angular-cli#4543 (comment)
I was unable to write unit test for the contents shown on ngx-bootstrap modal, as the BsModalService requires
window.getcomputedstyle().getpropertyvalue(), which is hard to polyfill in jsDom (used by Jest)
Code coverage using istanbul
In favour of readme file